During code review, pause before writing a suggested change. Ponder what prompted it, why it is necessary, whether it belongs now, and whether objective facts support it. Then choose Pass, Propose, or Postpone. section 6.1.1
Use the process to keep reviews focused and suggestions defensible:
- Pass when the suggestion is not valid or cannot yet be clearly explained; leave it out of the review. section 6.1.1
- Propose when the suggestion remains valid after reflection; state its rationale clearly in the review comment. section 6.1.1
- Postpone when the idea is worthwhile but inappropriate for the current review; record it for a later team discussion. section 6.1.1
A reviewer’s decision
A reviewer notices a possible improvement while examining a pull request. Instead of immediately adding review creep, the reviewer pauses, writes down the reason, checks whether the change is necessary now, and either omits it, proposes it with objective support, or saves it for team discussion. section 6.1.1 section 6.0
Figure 6.4 The 5P process for suggesting a change during a code review
Use the process diagram to navigate the pause-and-ponder decision and its three possible outcomes. section 6.1.1
