Use mobbing to perform much of the review in real time, then keep the pull request as a historical record of why the changes were made. Capture decisions, context, and key observations while the team works; a lighter review can then chronicle them. section 12.2.1
A lightweight chronicle records:
- Why the change was needed and what context shaped it. section 12.2.1
- Which decisions produced the chosen solution and how the team reached agreement. section 12.2.1
- Which alternatives were rejected, including solutions that initially seemed right but proved unsuitable. section 12.2.1
Table 12.1 Lightweight chronicle PR checklist
|
Checklist Item
|
Information to chronicle
|
Examples
|
|---|---|---|
|
Why/context
|
• Why are we making this change? What’s the context behind this change?
• What decisions led to this solution?
• How did we come to an agreement on this solution?
|
“This change addresses a really esoteric edge case we didn’t catch but recently caused a major production issue (#323).”
“We have to use this (rather than the FetchUser function available in version 9.3) because our internal packaging system is pinned to version 8.9.6. Until this has been updated company-wide, we have to continue using this workaround method.”
|
|
Skipped solutions
|
• What alternative solutions were discussed, and why were they skipped?
• What “gut-feeling” solutions turned out to be wrong?
|
“We considered Next.js, but they don’t seem to support relative paths for the exported content. They still have an open ticket on GitHub requesting this support, but they are ignoring it.”
“Lambda Functions incur an additional charge when writing to S3, so we skipped.”
|
|
Considerations (brought up during mobbing)
|
• Will these changes impact other teams?
• Other parts of the code base?
• Does this need to be deployed in a certain way?
|
“This needs to be feature-flagged until the corresponding ‘Seller’ component is ready.”
“With this refactor, we can remove the AccountUtilities library entirely. Let’s place that work in a separate PR, though!”
|
Use the lightweight chronicle PR checklist to turn mob-session notes into consistent historical context, including reasons, decisions, and skipped alternatives. section 12.2.1
