Review creep adds changes or work outside the original scope during code review, often creating unnecessary discussion. Before suggesting a change, clarify why it is necessary, timely, and objectively defensible. section 6.1.1
Use the 5P process before posting a review suggestion:
- Pause: stop before writing the comment. section 6.1.1
- Ponder: examine the trigger, necessity, timing, and objective justification. section 6.1.1
- Pass when the suggestion is unclear or cannot be explained. section 6.1.1
- Propose when the suggestion is valid and its rationale is understood. section 6.1.1
- Postpone suggestions that should not be introduced in the current review. section 6.1.1
Figure 6.4 The 5P process for suggesting a change during a code review
Use the 5P process diagram as a quick decision aid for deciding whether to pass, propose, or postpone a review suggestion. section 6.1.1
