liveBook · Manning

Merge blocker

As explained in Build High Value Software Systems

A review criterion or condition that prevents a proposed code change from being merged until the issue is resolved.

A merge blocker is an issue that must be resolved before a proposed code change can be merged. Review criteria make blocking decisions more consistent, while repeated deviations can signal that a team’s standards need clarification or revision. section 4.4.3

Block a change when it:

  • Fails to implement the spec, adds behavior outside it, or fails tests. section 4.4.3
  • Violates documented standards or introduces an undocumented pattern. section 4.4.3
  • Adds unjustified dependencies or hard-to-remove coupling. section 4.4.3
Figure 4.7 Using our standard work as a guide for PR reviews.

Use standard work as a guide when reviewing pull requests. section 4.4.3

How Build High Value Software Systems covers it

How deep it goes
Defines blocking criteria and a reviewer checklist, then treats repeated deviations as signals to revisit standards.
Examples
Uses spec mismatches, failed tests, unjustified dependencies, coupling, and inconsistent logging or error handling as review examples.
What you can do after
Evaluate proposed changes against explicit criteria and identify when recurring review issues warrant clearer or revised standards.
How it connects
Connects code review with documented standards, specifications, tests, and continuous improvement.

Related concepts

This explainer was generated by Manning's knowledge graph from the text of Build High Value Software Systems. The section links point to the parts of the book it draws on.