A merge blocker is an issue that must be resolved before a proposed code change can be merged. Review criteria make blocking decisions more consistent, while repeated deviations can signal that a team’s standards need clarification or revision. section 4.4.3
Block a change when it:
- Fails to implement the spec, adds behavior outside it, or fails tests. section 4.4.3
- Violates documented standards or introduces an undocumented pattern. section 4.4.3
- Adds unjustified dependencies or hard-to-remove coupling. section 4.4.3
Figure 4.7 Using our standard work as a guide for PR reviews.
Use standard work as a guide when reviewing pull requests. section 4.4.3
