liveBook · Manning

Nonblocking issue

As explained in "Looks Good to Me"

A code-review issue that may be recorded without preventing approval or integration of the change.

A nonblocking issue is a code-review concern that does not prevent a pull request from being approved or integrated under the team’s agreed policy. Teams decide this boundary together because severity and tolerance vary. section 3.3.3 section 4.2.3

Common nonblocking issues include:

  • Personal style preferences that differ from the team’s established coding style. section 3.3.3
  • Minor formatting discrepancies, such as inconsistent spacing or indentation. section 3.3.3
  • Documentation typos or minor inconsistencies. section 3.3.3
  • Optional features, minor refactors, or unrelated improvements that can be handled separately. section 3.3.3

Turn recurring judgments into policy

A reviewer may record a spacing inconsistency or suggest a small refactor without withholding approval. A missing core behavior should follow the team’s blocking-issue rules instead. Document such examples in the Team Working Agreement, revisit ambiguous cases in retrospectives, and distinguish withholding approval from rejecting a pull request. section 3.3.3 section 4.2.3

Figure 3.3 Blocking vs. nonblocking issues
figure

Use the blocking-versus-nonblocking comparison to classify review comments consistently. section 3.3.3

How "Looks Good to Me" covers it

How deep it goes
Lists common categories and recommends team-defined rules, but defers ambiguous severity judgments to discussion and retrospectives.
Examples
Uses style preferences, formatting discrepancies, documentation nitpicks, optional features, minor refactors, and unrelated improvements.
What it assumes
Assumes familiarity with pull requests and code review while teaching teams to define approval boundaries collaboratively.
What you can do after
Apply it via a team policy that classifies review comments and preserves approval for concerns suitable for later work.
How it connects
Connects code review with pull requests, coding style, approval policy, retrospectives, and team working agreements.

Related concepts

This explainer was generated by Manning's knowledge graph from the text of "Looks Good to Me". The section links point to the parts of the book it draws on.