liveBook · Manning

Offline conversation

As explained in "Looks Good to Me"

A direct discussion conducted outside the asynchronous code-review thread, typically in real time between the relevant participants.

Use an offline conversation to unblock a code review when asynchronous back-and-forth stops producing understanding. Move the discussion to a quick, real-time exchange while keeping the review thread informed. section 8.5

Start the conversation when:

  • Writing the reviewer’s questions takes longer than contacting the author. section 8.5
  • Multiple concerns, missing use cases, or misunderstood requirements require discussion rather than isolated comments. section 8.5
  • The reviewer has reread the pull-request description, linked documentation, supplemental information, and labels but remains blocked. section 8.5

A practical handoff

Leave a review comment summarizing the outstanding questions, state that an offline conversation with the author is next, then use messaging, an in-person conversation, or a video call. Return with an update for people following the review. section 8.5

How "Looks Good to Me" covers it

How deep it goes
Provides triggers, preparation checks, communication steps, and follow-up, but does not specify a detailed meeting agenda.
Examples
Uses piled-up reviewer questions, missing use cases, misunderstood requirements, messaging, in-person discussion, and video calls.
What it assumes
Assumes familiarity with pull-request review and expects reviewers to inspect available review information before escalating.
What you can do after
Apply it via a status comment, direct conversation, question summary, and subsequent review update.
How it connects
Connects code review with pull requests, review comments, requirements, and linked documentation.

Related concepts

This explainer was generated by Manning's knowledge graph from the text of "Looks Good to Me". The section links point to the parts of the book it draws on.