Technical discussion keeps code-review feedback focused on software properties, artifacts, and changes rather than a participant’s character. References to tests, files, and pull requests are associated with nontoxic discussion, while personal attacks shift attention away from the work. section 6.2
Use wording that makes the requested technical change collaborative and concrete:
- Basic: “You should move the Vehicle class to a separate file.” section 6.2
- Improved: “We should move the Vehicle class to a separate file.” section 6.2
- Advanced: “Can we move the Vehicle class to a separate file? This follows our team guidelines and will improve readability.” section 6.2
Figure 6.7 Nontoxic comment unigram breakdown. Technical terms, like “tests,” “files,” or “pull request” are statistically more likely to be found in comments labeled nontoxic.
Use the comparison of toxic and nontoxic comment vocabulary to distinguish personal attack from work-focused discussion. section 6.2
