liveBook · Manning

Approver

As explained in "Looks Good to Me"

A person authorized to approve a proposed code change for integration.

An approver is a person authorized to approve a proposed code change for integration. Teams use approvers to support knowledge transfer and codebase maintainability, while avoiding approval delays during urgent fixes. section 3.4.1

Set the approval policy according to both quality goals and operating conditions:

  • Require at least two approvers when shared review, knowledge transfer, and maintainability are the priority. section 3.4.1
  • Reconsider the policy when the minimum creates a bottleneck, especially during production incidents or teammate absences. section 3.4.1
  • Record the decision in the team working agreement and share the reasoning so later reviewers understand the change. section 3.4.1

Two approvers versus an emergency fix

A team requires two approvers for every pull request. After production fixes are delayed while key teammates are absent, the team discusses changing the rule. A single approver could reduce delays, but weakening the general policy may be too drastic; the team instead needs to address how regular and emergency changes should be handled. section 3.4.1

How "Looks Good to Me" covers it

How deep it goes
Examines approval-count tradeoffs, team disagreement, policy documentation, and tool limits, without specifying a final exception rule.
Examples
Uses a two-approver policy, absent teammates, delayed production fixes, and a tool unable to distinguish emergency scenarios.
What you can do after
Evaluate approval policies against maintainability goals, staffing constraints, emergency response needs, and available tool configuration.
How it connects
Connects approvers with code review, pull requests, knowledge transfer, maintainability, team agreements, and process bottlenecks.

Also explained in

Compare how 2 books explain approver →

Related concepts

This explainer was generated by Manning's knowledge graph from the text of "Looks Good to Me". The section links point to the parts of the book it draws on.