liveBook · Manning

Self-approval

As explained in "Looks Good to Me"

The approval of a pull request by the person who authored that pull request.

Self-approval is when the author of a pull request approves their own changes. It commonly conflicts with the team expectation that another person should review the work, but the right policy depends on team dynamics, tool enforcement, and emergency needs. section 4.4.5

When deciding how to handle self-approval, teams can choose among these approaches:

  • Prohibit self-approval through the team working agreement and review tooling. section 4.4.5
  • Permit it only during emergencies, using a dedicated emergency tag and a recorded justification. section 3.4.1
  • Keep the prohibition intact during emergencies by expanding the emergency approver pool to next-level managers. section 3.4.1

Controlled emergency approval

A team allows the author to count as a second approver only when a pull request carries the emergency tag. The author links a bug report or records why self-approval was necessary. The tool prompts for this justification, and the emergency playbook documents the procedure. section 3.4.1

How "Looks Good to Me" covers it

How deep it goes
Explains policy choices and enforcement steps, stopping short of technical details about pull-request tooling.
Examples
Uses emergency tags, bug-report links, justification records, manager approvers, and post-approval checks as concrete policy mechanisms.
What it assumes
Assumes familiarity with pull requests and peer review while examining how team norms and incentives shape approval behavior.
What you can do after
Operate/configure a self-approval policy with team-agreement rules, emergency safeguards, recorded justifications, and tool checks.
How it connects
Connects self-approval with pull requests, code review, team working agreements, emergency processes, and developer communication.

Related concepts

This explainer was generated by Manning's knowledge graph from the text of "Looks Good to Me". The section links point to the parts of the book it draws on.