liveBook · Manning

Code review policy

As explained in "Looks Good to Me"

An approval policy is a rule set specifying who may approve pull requests and how many approvals are required before integration.

A code review policy defines who may approve pull requests and how many approvals are required before integration. Start with those two decisions, then expand the rules only when the team needs more complexity. section 3.3.4

Choose the policy as a team, balancing review quality, knowledge sharing, permissions, and delivery speed.

  • Basic: allow team members who read or write code to approve, and require a single approval. section 3.3.4
  • Improved: use granular permissions when needed—for example, allowing a group to view while limiting which groups may approve particular pull requests. section 3.3.4
  • Advanced: require two approvers to support knowledge transfer and maintainability, while examining whether emergencies or absences create unacceptable delays. section 3.4.1

When enforcement defeats the policy

A team requires one approval per pull request, but authors ask for instant approvals in chat. Whoever sees the request approves without checking the code, and a QA engineer approves nearly everything. The policy exists, yet the workaround produces ineffective reviews, resentment, and stress. Treat enforcement and review quality as part of the policy’s practical design. section 7.1.1

Review the policy collaboratively after trying it. Record the decision and its rationale in the team’s working agreement, announce changes, and refine the rule when circumstances expose a bottleneck. section 3.4.1 section 3.5

How "Looks Good to Me" covers it

How deep it goes
Explains approver eligibility, approval counts, permission granularity, and policy refinement, but stops short of prescribing one universal rule.
Examples
Uses one- and two-approver rules, granular reviewer permissions, informational reviewers, chat workarounds, and serial approval.
What it assumes
Assumes a pull-request workflow and review tooling, while teaching approval roles, counts, permissions, and collaborative refinement.
What you can do after
Operate/configure approval requirements, communicate them, detect harmful workarounds, and refine them through team discussion.
How it connects
Connects pull requests with code review workflow, team working agreements, knowledge transfer, codebase maintainability, and emergency scenarios.

Related concepts

This explainer was generated by Manning's knowledge graph from the text of "Looks Good to Me". The section links point to the parts of the book it draws on.