liveBook · Manning

Pull request privilege

As explained in "Looks Good to Me"

An authorization that allows a person or group to approve a pull request.

A team is blocked when every pull request waits for one senior developer. Pull request privilege is the authorization to approve a pull request, and teams can assign it broadly or restrict it by person, group, or change type. Start by deciding who may approve and how many approvals a merge requires; add finer rules only when the team needs them. section 3.3.4 section 8.1

Choose an approval model that matches the team’s context:

  • Give every development team member approval privileges, including newer or junior developers, so review responsibility does not bottleneck around seniority. section 8.1
  • Use granular permissions when needed: one group may view a pull request, another may approve it, or approval may depend on the affected pull requests. section 3.3.4
  • Support broad approval with safeguards such as continuous integration checks, unit and integration tests, staged environments, easy reverts, and shared accountability. section 8.1
  • Document consequences for serious violations, such as revoking privileges after unauthorized self-approval, and raise violations in retrospectives or one-on-ones. section 4.4.8

Replacing the senior-review bottleneck

A team formerly waited for its sole senior developer to approve every pull request. It expands approval privileges to the whole development team, keeps automated checks and tests mandatory, and makes each approver accountable for helping resolve problems. The team then records that unauthorized self-approval can revoke the privilege. section 8.1 section 4.4.8

How "Looks Good to Me" covers it

How deep it goes
Explains binary and granular permission choices, approval counts, safeguards, and policy violations without specifying tool-level configuration steps.
Examples
Uses the single senior reviewer bottleneck, informational reviewers with accountability, and unauthorized self-approval as concrete cases.
What it assumes
Assumes familiarity with pull requests and team review, while establishing the basic questions of approver eligibility and required approval count.
What you can do after
Operate/configure an approval policy that distributes review authority, sets approval requirements, adds safeguards, and responds to violations.
How it connects
Connects pull request privilege with code review, continuous integration, automated testing, deployment environments, reverts, and team working agreements.

Related concepts

This explainer was generated by Manning's knowledge graph from the text of "Looks Good to Me". The section links point to the parts of the book it draws on.