Code smell
A code smell is a recognizable characteristic of source code that suggests a potential design, implementation, or maintainability problem, without necessarily indicating a functional defect.
Grokking Simplicity
A code smell is a characteristic of source code that may indicate deeper design or maintenance problems.
- How it is used
- Uses smells as practical signals for finding duplication, misplaced abstractions, and opportunities to refactor code.
- How deep it goes
- Defines smells, identifies their characteristics, and gives step-by-step refactorings, but does not provide a complete taxonomy.
- Examples
- Uses shipping calculations, repeated cart setters, and a mixed DOM-and-cart update function as diagnostic examples.
- What you can do after
- Diagnose potential design problems and apply refactorings that expose arguments, reduce duplication, and separate responsibilities.
"Looks Good to Me"
A code smell is a recognizable symptom in source code that suggests a possible design, maintainability, or implementation problem.
- How it is used
- Uses code smells as maintainability signals during pull-request review and automated quality checks.
- How deep it goes
- Defines symptoms and review handling, then extends to automated detection and refactoring without cataloging specific smell patterns.
- Examples
- Uses pull-request approval decisions, AI review findings, refactoring suggestions, and recurring-review feedback as examples.
- What you can do after
- Diagnose code-quality signals, calibrate blocking decisions, and use automated feedback to refactor recurring problems earlier.
Also covered in
- Build High Value Software SystemsIn early access (MEAP)
- Think Like a Software Engineering Manager
- The Creative Programmer
- Grokking Software ArchitectureIn early access (MEAP)
What to know first
- code duplicationCode duplication is the presence of the same or substantially similar implementation logic in multiple locations within a software system.
- design patternA design pattern is a reusable, general solution structure for a recurring software design problem.
- couplingCoupling is the degree of interdependence between software components, including their dependencies on one another’s structure, behavior, or availability.
- refactoringRefactoring is the disciplined restructuring of existing software to improve its internal qualities while preserving its externally observable behavior.
Related concepts
- implicit argumentincludes · An implicit argument is a function input supplied through context or language conventions rather than explicitly provided at the call site.
- code duplicationincludes · Code duplication is the presence of the same or substantially similar implementation logic in multiple locations within a software system.
- community smellproduced by · A recurring social or organizational dysfunction in a software-development community that impairs collaboration, communication, or software outcomes.
- eight wastesuses · The eight recurring Lean categories of effort that fails to translate into useful outcomes: transport, inventory, motion, waiting, overproduction, overprocessing, defects, and unused skills.
- refactoringaddressed by · Refactoring is the disciplined restructuring of existing software to improve its internal qualities while preserving its externally observable behavior.
Questions about code smell
What is code smell?
A code smell is a recognizable characteristic of source code that suggests a potential design, implementation, or maintainability problem, without necessarily indicating a functional defect.
Which Manning books explain code smell?
Grokking Simplicity and "Looks Good to Me".
What should I know before learning code smell?
Manning books that teach code smell usually introduce code duplication, design pattern, coupling and refactoring first.
What kinds of code smell are there?
Kinds of code smell include implicit argument, code duplication and long method.
These guides are generated from the text of Manning books by Manning's knowledge graph and link to the sections they draw on. The full books are available on liveBook and at manning.com.

